Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add show_wfs_during_program function #798

Merged
merged 5 commits into from
Apr 1, 2024
Merged

add show_wfs_during_program function #798

merged 5 commits into from
Apr 1, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Feb 6, 2024 •
edited
Loading

Adds a function show_wfs_during_program that displays the WFS measurements for the entire duration of time in which some observing program was conducted. Intended for quick-look analyses of "was the wavefront particularly discrepant at any point in this whole series of observations". This just shows RMS WFE; more detailed tools like the monthly_trending_plot can show the specific delta OPDs if a time period of interest is determined.

Some example outputs:

webbpsf.trending.show_wfs_during_program(1277)
webbpsf.trending.show_wfs_during_program(1685)

Unknown-8
Unknown-11

@mperrin mperrin requested a review from obi-wan76 February 6, 2024 20:37
@mperrin mperrin self-assigned this Feb 6, 2024
@pep8speaks
Copy link

pep8speaks commented Feb 6, 2024 •
edited
Loading

Hello @mperrin, Thank you for updating !

Line 16:1: E266 too many leading '#' for block comment
Line 46:72: E703 statement ends with a semicolon
Line 60:1: E266 too many leading '#' for block comment
Line 86:9: E265 block comment should start with '# '
Line 91:27: E226 missing whitespace around arithmetic operator
Line 104:23: E226 missing whitespace around arithmetic operator
Line 105:23: E701 multiple statements on one line (colon)
Line 113:27: E701 multiple statements on one line (colon)
Line 204:19: E701 multiple statements on one line (colon)
Line 208:19: E701 multiple statements on one line (colon)
Line 212:19: E701 multiple statements on one line (colon)
Line 218:9: E122 continuation line missing indentation or outdented
Line 219:19: E701 multiple statements on one line (colon)
Line 221:57: E251 unexpected spaces around keyword / parameter equals
Line 221:59: E251 unexpected spaces around keyword / parameter equals
Line 225:1: E266 too many leading '#' for block comment
Line 225:1: E303 too many blank lines (3)
Line 227:1: E302 expected 2 blank lines, found 3
Line 298:1: E266 too many leading '#' for block comment
Line 349:5: E303 too many blank lines (2)
Line 376:1: E302 expected 2 blank lines, found 1
Line 386:13: E128 continuation line under-indented for visual indent
Line 394:1: E302 expected 2 blank lines, found 1
Line 464:5: E265 block comment should start with '# '
Line 465:5: E265 block comment should start with '# '
Line 471:33: E231 missing whitespace after ','
Line 479:5: E265 block comment should start with '# '
Line 485:23: E701 multiple statements on one line (colon)
Line 495:23: E701 multiple statements on one line (colon)
Line 560:40: E701 multiple statements on one line (colon)
Line 601:13: E126 continuation line over-indented for hanging indent
Line 601:39: E261 at least two spaces before inline comment
Line 604:12: E126 continuation line over-indented for hanging indent
Line 607:29: E203 whitespace before ':'
Line 607:43: E203 whitespace before ':'
Line 610:5: E303 too many blank lines (2)
Line 612:11: E128 continuation line under-indented for visual indent
Line 613:10: E124 closing bracket does not match visual indentation
Line 650:24: E231 missing whitespace after ':'
Line 654:17: E124 closing bracket does not match visual indentation
Line 662:29: E203 whitespace before ':'
Line 662:43: E203 whitespace before ':'
Line 665:5: E303 too many blank lines (2)
Line 665:41: E231 missing whitespace after ','
Line 677:5: E303 too many blank lines (2)
Line 680:28: E201 whitespace after '('
Line 680:33: E226 missing whitespace around arithmetic operator
Line 682:16: E225 missing whitespace around operator
Line 685:1: E302 expected 2 blank lines, found 1
Line 685:39: E241 multiple spaces after ','
Line 710:5: E303 too many blank lines (2)
Line 711:13: E225 missing whitespace around operator
Line 714:5: E265 block comment should start with '# '

Line 20:1: E302 expected 2 blank lines, found 1
Line 27:1: E302 expected 2 blank lines, found 1
Line 30:88: E261 at least two spaces before inline comment
Line 33:33: E128 continuation line under-indented for visual indent
Line 84:15: E265 block comment should start with '# '
Line 86:15: E265 block comment should start with '# '
Line 87:15: E265 block comment should start with '# '
Line 93:15: E265 block comment should start with '# '
Line 102:56: E261 at least two spaces before inline comment
Line 128:25: E226 missing whitespace around arithmetic operator
Line 130:25: E226 missing whitespace around arithmetic operator
Line 135:47: E226 missing whitespace around arithmetic operator
Line 156:13: E265 block comment should start with '# '
Line 189:1: E303 too many blank lines (3)
Line 190:25: E127 continuation line over-indented for visual indent
Line 220:5: E303 too many blank lines (2)
Line 236:10: E225 missing whitespace around operator
Line 248:25: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 250:27: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 257:73: E226 missing whitespace around arithmetic operator
Line 260:64: E231 missing whitespace after ','
Line 278:10: E221 multiple spaces before operator
Line 279:41: E231 missing whitespace after ','
Line 279:71: E251 unexpected spaces around keyword / parameter equals
Line 279:73: E251 unexpected spaces around keyword / parameter equals
Line 279:83: E231 missing whitespace after ':'
Line 281:12: E261 at least two spaces before inline comment
Line 281:13: E262 inline comment should start with '# '
Line 283:57: E226 missing whitespace around arithmetic operator
Line 288:24: E225 missing whitespace around operator
Line 297:26: E225 missing whitespace around operator
Line 298:34: E226 missing whitespace around arithmetic operator
Line 298:47: E225 missing whitespace around operator
Line 299:81: E226 missing whitespace around arithmetic operator
Line 301:26: E225 missing whitespace around operator
Line 302:17: E222 multiple spaces after operator
Line 302:36: E226 missing whitespace around arithmetic operator
Line 304:50: E226 missing whitespace around arithmetic operator
Line 306:23: E221 multiple spaces before operator
Line 308:18: E222 multiple spaces after operator
Line 308:24: E226 missing whitespace around arithmetic operator
Line 317:31: E226 missing whitespace around arithmetic operator
Line 317:35: E226 missing whitespace around arithmetic operator
Line 318:33: E226 missing whitespace around arithmetic operator
Line 322:31: E226 missing whitespace around arithmetic operator
Line 322:60: E226 missing whitespace around arithmetic operator
Line 325:11: E221 multiple spaces before operator
Line 331:22: E128 continuation line under-indented for visual indent
Line 336:60: E251 unexpected spaces around keyword / parameter equals
Line 336:62: E251 unexpected spaces around keyword / parameter equals
Line 338:10: E225 missing whitespace around operator
Line 340:23: E201 whitespace after '('
Line 340:43: E226 missing whitespace around arithmetic operator
Line 341:23: E201 whitespace after '('
Line 341:43: E226 missing whitespace around arithmetic operator
Line 344:22: E128 continuation line under-indented for visual indent
Line 346:44: E226 missing whitespace around arithmetic operator
Line 352:31: E226 missing whitespace around arithmetic operator
Line 352:111: E703 statement ends with a semicolon
Line 357:30: E226 missing whitespace around arithmetic operator
Line 362:24: E231 missing whitespace after ','
Line 368:37: E226 missing whitespace around arithmetic operator
Line 368:57: E226 missing whitespace around arithmetic operator
Line 369:30: E226 missing whitespace around arithmetic operator
Line 369:35: E226 missing whitespace around arithmetic operator
Line 369:41: E226 missing whitespace around arithmetic operator
Line 369:53: E226 missing whitespace around arithmetic operator
Line 370:22: E128 continuation line under-indented for visual indent
Line 371:21: E128 continuation line under-indented for visual indent
Line 374:5: E303 too many blank lines (2)
Line 378:50: E226 missing whitespace around arithmetic operator
Line 379:17: E225 missing whitespace around operator
Line 387:1: E266 too many leading '#' for block comment
Line 389:1: E302 expected 2 blank lines, found 1
Line 413:35: E226 missing whitespace around arithmetic operator
Line 425:35: E226 missing whitespace around arithmetic operator
Line 426:20: E128 continuation line under-indented for visual indent
Line 427:20: E128 continuation line under-indented for visual indent
Line 428:20: E128 continuation line under-indented for visual indent
Line 431:5: E303 too many blank lines (2)
Line 512:67: E225 missing whitespace around operator
Line 518:5: E303 too many blank lines (2)
Line 534:75: E231 missing whitespace after ':'
Line 534:81: E226 missing whitespace around arithmetic operator
Line 535:44: E225 missing whitespace around operator
Line 575:5: E303 too many blank lines (2)
Line 581:30: E225 missing whitespace around operator
Line 586:5: E266 too many leading '#' for block comment
Line 586:5: E303 too many blank lines (2)
Line 600:5: E266 too many leading '#' for block comment
Line 600:5: E303 too many blank lines (2)
Line 601:13: E225 missing whitespace around operator
Line 605:81: E226 missing whitespace around arithmetic operator
Line 610:102: E226 missing whitespace around arithmetic operator
Line 636:5: E266 too many leading '#' for block comment
Line 642:92: E226 missing whitespace around arithmetic operator
Line 647:91: E226 missing whitespace around arithmetic operator
Line 652:74: E226 missing whitespace around arithmetic operator
Line 657:70: E226 missing whitespace around arithmetic operator
Line 659:5: E266 too many leading '#' for block comment
Line 664:75: E226 missing whitespace around arithmetic operator
Line 669:66: E226 missing whitespace around arithmetic operator
Line 677:60: E225 missing whitespace around operator
Line 680:93: E226 missing whitespace around arithmetic operator
Line 685:5: E303 too many blank lines (2)
Line 687:78: E226 missing whitespace around arithmetic operator
Line 692:70: E226 missing whitespace around arithmetic operator
Line 740:5: E303 too many blank lines (2)
Line 761:1: E305 expected 2 blank lines after class or function definition, found 1
Line 816:19: E701 multiple statements on one line (colon)
Line 819:5: E303 too many blank lines (2)
Line 819:74: W504 line break after binary operator
Line 826:5: E266 too many leading '#' for block comment
Line 870:48: E226 missing whitespace around arithmetic operator
Line 910:49: W605 invalid escape sequence '\D'
Line 942:1: E266 too many leading '#' for block comment
Line 955:46: E241 multiple spaces after ','
Line 972:43: E203 whitespace before ':'
Line 987:1: E303 too many blank lines (3)
Line 1044:5: E303 too many blank lines (2)
Line 1047:47: E225 missing whitespace around operator
Line 1048:18: E221 multiple spaces before operator
Line 1050:70: E225 missing whitespace around operator
Line 1051:75: E202 whitespace before ']'
Line 1060:51: E261 at least two spaces before inline comment
Line 1060:51: E262 inline comment should start with '# '
Line 1061:41: E201 whitespace after '('
Line 1061:64: E202 whitespace before ')'
Line 1064:5: E722 do not use bare 'except'
Line 1085:5: E303 too many blank lines (2)
Line 1086:19: E701 multiple statements on one line (colon)
Line 1171:98: W504 line break after binary operator
Line 1196:49: E231 missing whitespace after ','
Line 1207:5: E266 too many leading '#' for block comment
Line 1219:5: E265 block comment should start with '# '
Line 1219:5: E303 too many blank lines (2)
Line 1220:5: E265 block comment should start with '# '
Line 1221:26: E201 whitespace after '('
Line 1222:30: E231 missing whitespace after ','
Line 1224:25: E226 missing whitespace around arithmetic operator
Line 1224:39: E226 missing whitespace around arithmetic operator
Line 1224:48: E226 missing whitespace around arithmetic operator
Line 1224:62: E226 missing whitespace around arithmetic operator
Line 1228:5: E266 too many leading '#' for block comment
Line 1239:60: E226 missing whitespace around arithmetic operator
Line 1239:71: E226 missing whitespace around arithmetic operator
Line 1239:88: E226 missing whitespace around arithmetic operator
Line 1239:94: E261 at least two spaces before inline comment
Line 1241:74: E226 missing whitespace around arithmetic operator
Line 1242:36: W605 invalid escape sequence '\D'
Line 1244:32: E226 missing whitespace around arithmetic operator
Line 1244:34: E226 missing whitespace around arithmetic operator
Line 1248:26: E201 whitespace after '('
Line 1256:5: E303 too many blank lines (2)
Line 1269:49: E226 missing whitespace around arithmetic operator
Line 1270:23: E225 missing whitespace around operator
Line 1270:32: E225 missing whitespace around operator
Line 1302:146: E226 missing whitespace around arithmetic operator
Line 1305:132: E226 missing whitespace around arithmetic operator
Line 1325:30: E261 at least two spaces before inline comment
Line 1327:134: E226 missing whitespace around arithmetic operator
Line 1330:132: E226 missing whitespace around arithmetic operator
Line 1338:22: E231 missing whitespace after ','
Line 1341:46: E251 unexpected spaces around keyword / parameter equals
Line 1341:48: E251 unexpected spaces around keyword / parameter equals
Line 1346:48: E226 missing whitespace around arithmetic operator
Line 1346:52: E226 missing whitespace around arithmetic operator
Line 1346:66: E226 missing whitespace around arithmetic operator
Line 1346:70: E226 missing whitespace around arithmetic operator
Line 1347:40: E128 continuation line under-indented for visual indent
Line 1377:5: E303 too many blank lines (2)
Line 1389:50: E226 missing whitespace around arithmetic operator
Line 1389:54: E226 missing whitespace around arithmetic operator
Line 1389:82: E226 missing whitespace around arithmetic operator
Line 1392:69: E226 missing whitespace around arithmetic operator
Line 1393:67: E231 missing whitespace after ','
Line 1395:69: E226 missing whitespace around arithmetic operator
Line 1396:67: E231 missing whitespace after ','
Line 1400:5: E303 too many blank lines (3)
Line 1401:41: E231 missing whitespace after ','
Line 1401:83: E231 missing whitespace after ':'
Line 1401:97: E231 missing whitespace after ':'
Line 1401:112: E231 missing whitespace after ':'
Line 1402:85: E231 missing whitespace after ':'
Line 1402:97: E231 missing whitespace after ':'
Line 1405:5: E303 too many blank lines (2)
Line 1405:11: E231 missing whitespace after ','
Line 1406:11: E231 missing whitespace after ','
Line 1408:11: E231 missing whitespace after ','
Line 1408:29: E226 missing whitespace around arithmetic operator
Line 1409:11: E231 missing whitespace after ','
Line 1409:29: E226 missing whitespace around arithmetic operator
Line 1411:11: E231 missing whitespace after ','
Line 1411:28: E226 missing whitespace around arithmetic operator
Line 1411:36: E226 missing whitespace around arithmetic operator
Line 1412:11: E231 missing whitespace after ','
Line 1412:28: E226 missing whitespace around arithmetic operator
Line 1412:36: E226 missing whitespace around arithmetic operator
Line 1415:5: E303 too many blank lines (2)
Line 1416:41: E226 missing whitespace around arithmetic operator
Line 1416:48: E226 missing whitespace around arithmetic operator
Line 1417:41: E226 missing whitespace around arithmetic operator
Line 1417:48: E226 missing whitespace around arithmetic operator
Line 1418:11: E231 missing whitespace after ','
Line 1418:22: E231 missing whitespace after ','
Line 1419:11: E231 missing whitespace after ','
Line 1419:22: E231 missing whitespace after ','
Line 1422:5: E303 too many blank lines (2)
Line 1422:11: E231 missing whitespace after ','
Line 1423:11: E231 missing whitespace after ','
Line 1424:11: E231 missing whitespace after ','
Line 1425:11: E231 missing whitespace after ','
Line 1426:11: E231 missing whitespace after ','
Line 1431:5: E303 too many blank lines (2)
Line 1432:26: E251 unexpected spaces around keyword / parameter equals
Line 1432:28: E251 unexpected spaces around keyword / parameter equals
Line 1432:35: E231 missing whitespace after ','
Line 1432:94: E202 whitespace before ')'
Line 1480:5: E303 too many blank lines (2)
Line 1485:51: E226 missing whitespace around arithmetic operator
Line 1485:55: E226 missing whitespace around arithmetic operator
Line 1485:84: E225 missing whitespace around operator
Line 1488:71: E226 missing whitespace around arithmetic operator
Line 1489:69: E231 missing whitespace after ','
Line 1491:71: E226 missing whitespace around arithmetic operator
Line 1492:69: E231 missing whitespace after ','
Line 1495:5: E303 too many blank lines (2)
Line 1496:41: E231 missing whitespace after ','
Line 1496:83: E231 missing whitespace after ':'
Line 1496:96: E231 missing whitespace after ':'
Line 1496:110: E231 missing whitespace after ':'
Line 1497:76: E128 continuation line under-indented for visual indent
Line 1497:84: E231 missing whitespace after ':'
Line 1497:96: E231 missing whitespace after ':'
Line 1500:5: E303 too many blank lines (2)
Line 1500:11: E231 missing whitespace after ','
Line 1501:11: E231 missing whitespace after ','
Line 1503:11: E231 missing whitespace after ','
Line 1503:29: E226 missing whitespace around arithmetic operator
Line 1504:11: E231 missing whitespace after ','
Line 1504:29: E226 missing whitespace around arithmetic operator
Line 1506:11: E231 missing whitespace after ','
Line 1506:29: E226 missing whitespace around arithmetic operator
Line 1506:38: E226 missing whitespace around arithmetic operator
Line 1507:11: E231 missing whitespace after ','
Line 1507:29: E226 missing whitespace around arithmetic operator
Line 1507:38: E226 missing whitespace around arithmetic operator
Line 1510:42: E226 missing whitespace around arithmetic operator
Line 1510:51: E226 missing whitespace around arithmetic operator
Line 1511:42: E226 missing whitespace around arithmetic operator
Line 1511:51: E226 missing whitespace around arithmetic operator
Line 1512:11: E231 missing whitespace after ','
Line 1512:21: E231 missing whitespace after ','
Line 1513:11: E231 missing whitespace after ','
Line 1513:21: E231 missing whitespace after ','
Line 1517:5: E303 too many blank lines (3)
Line 1517:11: E231 missing whitespace after ','
Line 1518:11: E231 missing whitespace after ','
Line 1519:11: E231 missing whitespace after ','
Line 1520:11: E231 missing whitespace after ','
Line 1521:11: E231 missing whitespace after ','
Line 1526:5: E303 too many blank lines (2)
Line 1527:26: E251 unexpected spaces around keyword / parameter equals
Line 1527:28: E251 unexpected spaces around keyword / parameter equals
Line 1527:35: E231 missing whitespace after ','
Line 1527:94: E202 whitespace before ')'
Line 1530:5: E303 too many blank lines (2)
Line 1552:5: E731 do not assign a lambda expression, use a def
Line 1555:19: E701 multiple statements on one line (colon)
Line 1559:16: E225 missing whitespace around operator
Line 1581:33: E231 missing whitespace after ','
Line 1583:85: E231 missing whitespace after ','
Line 1591:5: E303 too many blank lines (2)
Line 1593:18: E128 continuation line under-indented for visual indent
Line 1593:20: E231 missing whitespace after ','
Line 1593:22: E231 missing whitespace after ','
Line 1606:35: E231 missing whitespace after ','
Line 1609:15: E201 whitespace after '('
Line 1609:35: E226 missing whitespace around arithmetic operator
Line 1609:44: E226 missing whitespace around arithmetic operator
Line 1609:64: E226 missing whitespace around arithmetic operator
Line 1610:15: E128 continuation line under-indented for visual indent
Line 1611:14: E128 continuation line under-indented for visual indent
Line 1612:15: E201 whitespace after '('
Line 1612:24: E226 missing whitespace around arithmetic operator
Line 1612:43: E226 missing whitespace around arithmetic operator
Line 1612:52: E226 missing whitespace around arithmetic operator
Line 1613:15: E128 continuation line under-indented for visual indent
Line 1614:14: E128 continuation line under-indented for visual indent
Line 1619:20: E128 continuation line under-indented for visual indent
Line 1623:35: E226 missing whitespace around arithmetic operator
Line 1624:39: E226 missing whitespace around arithmetic operator
Line 1624:48: E226 missing whitespace around arithmetic operator
Line 1625:28: E226 missing whitespace around arithmetic operator
Line 1625:48: E226 missing whitespace around arithmetic operator
Line 1630:14: E128 continuation line under-indented for visual indent
Line 1633:5: E303 too many blank lines (2)
Line 1636:19: E225 missing whitespace around operator
Line 1639:9: E225 missing whitespace around operator
Line 1640:47: E226 missing whitespace around arithmetic operator
Line 1640:55: E226 missing whitespace around arithmetic operator
Line 1642:49: E226 missing whitespace around arithmetic operator
Line 1642:57: E226 missing whitespace around arithmetic operator
Line 1644:46: E226 missing whitespace around arithmetic operator
Line 1644:54: E226 missing whitespace around arithmetic operator
Line 1647:47: E226 missing whitespace around arithmetic operator
Line 1647:59: E226 missing whitespace around arithmetic operator
Line 1647:67: E226 missing whitespace around arithmetic operator
Line 1651:55: E251 unexpected spaces around keyword / parameter equals
Line 1651:57: E251 unexpected spaces around keyword / parameter equals
Line 1693:5: E303 too many blank lines (2)
Line 1696:57: E226 missing whitespace around arithmetic operator
Line 1696:64: E226 missing whitespace around arithmetic operator
Line 1702:19: E222 multiple spaces after operator
Line 1724:53: E226 missing whitespace around arithmetic operator
Line 1731:31: E225 missing whitespace around operator
Line 1737:5: E303 too many blank lines (2)
Line 1742:32: E226 missing whitespace around arithmetic operator
Line 1753:33: E225 missing whitespace around operator
Line 1754:51: E226 missing whitespace around arithmetic operator
Line 1758:42: E231 missing whitespace after ','
Line 1762:56: E231 missing whitespace after ','
Line 1767:28: E226 missing whitespace around arithmetic operator
Line 1767:87: E203 whitespace before ','
Line 1770:28: E231 missing whitespace after ','
Line 1771:25: E128 continuation line under-indented for visual indent
Line 1772:55: E226 missing whitespace around arithmetic operator
Line 1774:18: E231 missing whitespace after ','
Line 1783:1: E266 too many leading '#' for block comment
Line 1783:1: E303 too many blank lines (3)
Line 1784:1: E302 expected 2 blank lines, found 3
Line 1799:5: E303 too many blank lines (2)
Line 1799:52: E251 unexpected spaces around keyword / parameter equals
Line 1799:54: E251 unexpected spaces around keyword / parameter equals
Line 1799:59: E226 missing whitespace around arithmetic operator
Line 1799:77: E261 at least two spaces before inline comment
Line 1799:78: E262 inline comment should start with '# '
Line 1800:47: E226 missing whitespace around arithmetic operator
Line 1803:5: E303 too many blank lines (2)
Line 1812:5: E303 too many blank lines (2)
Line 1815:1: E302 expected 2 blank lines, found 1
Line 1826:41: E231 missing whitespace after ','
Line 1842:90: E231 missing whitespace after ','
Line 1850:43: E226 missing whitespace around arithmetic operator
Line 1856:22: E225 missing whitespace around operator
Line 1864:19: E126 continuation line over-indented for hanging indent
Line 1865:27: E251 unexpected spaces around keyword / parameter equals
Line 1865:29: E251 unexpected spaces around keyword / parameter equals
Line 1865:82: E225 missing whitespace around operator
Line 1869:21: E128 continuation line under-indented for visual indent
Line 1874:5: E303 too many blank lines (2)

Comment last updated at 2024-04-01 18:18:16 UTC

@mperrin mperrin added enhancement New feature or request JWST Affects JWST models in WebbPSF labels Feb 6, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.33945% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 59.23%. Comparing base (2c64988) to head (17bd676).

Files Patch % Lines
webbpsf/trending.py 7.89% 70 Missing ⚠️
webbpsf/mast_wss.py 6.06% 31 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #798      +/-   ##
===========================================
- Coverage    60.08%   59.23%   -0.86%     
===========================================
  Files           16       16              
  Lines         6732     6839     +107     
===========================================
+ Hits          4045     4051       +6     
- Misses        2687     2788     +101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mperrin mperrin added this to the Release 1.3 milestone Feb 13, 2024
@mperrin mperrin changed the title add show_wfs_around_obs function add show_wfs_during_program function Feb 19, 2024
@mperrin mperrin force-pushed the add_show_wfs_during_program branch from e611ed1 to e83fae6 Compare February 19, 2024 15:16
@mperrin
Copy link
Collaborator Author

mperrin commented Feb 19, 2024

This PR rebased onto develop and deconflicted. Necessary to handle conflicts with overlapping edits from #802.

@mperrin
Copy link
Collaborator Author

mperrin commented Feb 22, 2024

@obi-wan76 Wanted to ping you about this and ask if you will be able to review this PR, and if so by when?

@mperrin mperrin force-pushed the add_show_wfs_during_program branch from 771e32f to bbb5029 Compare March 28, 2024 15:56
obi-wan76
obi-wan76 reviewed Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't download OPDs automatically for that particular PID, is this correct? so the user needs to download the OPDs before running this function. Can you make it that if the OPD doesn't exist in the path then it download the OPD.

@obi-wan76
Copy link
Collaborator

Once you have all the OPDs it works as intended.
Screen Shot 2024-03-30 at 3 41 51 PM

@mperrin mperrin force-pushed the add_show_wfs_during_program branch from bbb5029 to 17bd676 Compare April 1, 2024 18:18
@mperrin mperrin requested a review from obi-wan76 April 1, 2024 18:18
@mperrin
Copy link
Collaborator Author

mperrin commented Apr 1, 2024

Added the requested functionality for auto download of OPD.

obi-wan76
obi-wan76 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried with one of our own programs and dowloaded everything, this is a great addition.
Screen Shot 2024-04-01 at 3 41 57 PM

@obi-wan76 obi-wan76 merged commit 2669f27 into spacetelescope:develop Apr 1, 2024
7 of 9 checks passed
@mperrin mperrin deleted the add_show_wfs_during_program branch April 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obi-wan76 obi-wan76 obi-wan76 approved these changes

Assignees

@mperrin mperrin

Labels
enhancement New feature or request JWST Affects JWST models in WebbPSF
Projects
None yet
Milestone
Release 1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mperrin @pep8speaks @obi-wan76